Jelajahi Sumber

使用final修饰了一些注入类

verguenza 5 tahun lalu
induk
melakukan
728573a40a

+ 4 - 4
src/main/java/com/galaxis/manatee/service/DingTalkScheduledTask.java

@@ -31,17 +31,17 @@ public class DingTalkScheduledTask {
     /**
      * 审批Id列表客户端
      */
-    private DingTalkClient processInstanceListIdsClient;
+    private final DingTalkClient processInstanceListIdsClient;
 
     /**
      * 审批实例客户端
      */
-    private DingTalkClient processInstanceClient;
+    private final DingTalkClient processInstanceClient;
 
     /**
      * 钉钉审批实例保存方法
      */
-    private DingTalkProcessInstanceDao dingTalkProcessInstanceDao;
+    private final DingTalkProcessInstanceDao dingTalkProcessInstanceDao;
 
     public DingTalkScheduledTask(DingTalkClient processInstanceListIdsClient, DingTalkClient processInstanceClient, DingTalkProcessInstanceDao dingTalkProcessInstanceDao) {
         this.processInstanceListIdsClient = processInstanceListIdsClient;
@@ -97,7 +97,7 @@ public class DingTalkScheduledTask {
             //逐个请求
             oapiProcessinstanceListidsResponse.getResult().getList().forEach(resultId->{
                 Optional<DingTalkProcessInstance> instance=dingTalkProcessInstanceDao.findById(resultId);
-                if(!instance.isEmpty()){
+                if(!instance.isPresent()){
                     //&&instance.get()==null
                     //淘宝SDK方法
                     OapiProcessinstanceGetRequest request=new OapiProcessinstanceGetRequest();

+ 1 - 1
src/main/java/com/galaxis/manatee/util/AliSmsUtil.java

@@ -22,7 +22,7 @@ public class AliSmsUtil {
     /**
      * 手机号校验正则表达式
      */
-    private static Pattern mobilePattern=Pattern.compile("^[1][3,4,5,7,8][0-9]{9}$");
+    private static final Pattern mobilePattern=Pattern.compile("^[1][3,4,5,7,8][0-9]{9}$");
 
     /**
      * 手机号验证

+ 1 - 3
src/main/java/com/galaxis/manatee/util/DingTalkRobotUtils.java

@@ -4,7 +4,6 @@ import org.apache.tomcat.util.codec.binary.Base64;
 
 import javax.crypto.Mac;
 import javax.crypto.spec.SecretKeySpec;
-import java.io.UnsupportedEncodingException;
 import java.net.URLEncoder;
 import java.nio.charset.StandardCharsets;
 import java.security.InvalidKeyException;
@@ -23,10 +22,9 @@ public class DingTalkRobotUtils {
      * @param timestamp     时间戳
      * @return  完成签名的
      * @throws NoSuchAlgorithmException     算法名不对的异常
-     * @throws UnsupportedEncodingException 不支持的编码
      * @throws InvalidKeyException          非法的关键字
      */
-    public static String sign(String secret,Long timestamp) throws NoSuchAlgorithmException, UnsupportedEncodingException, InvalidKeyException {
+    public static String sign(String secret,Long timestamp) throws NoSuchAlgorithmException, InvalidKeyException {
         var stringToSign = timestamp + "\n" + secret;
         var mac = Mac.getInstance("HmacSHA256");
         mac.init(new SecretKeySpec(secret.getBytes(StandardCharsets.UTF_8), "HmacSHA256"));

+ 0 - 15
src/main/java/com/galaxis/manatee/util/impl/JwtUtil.java

@@ -1,15 +0,0 @@
-package com.galaxis.manatee.util.impl;
-
-import org.springframework.beans.factory.annotation.Value;
-
-import java.io.Serializable;
-import java.util.Map;
-
-/**
- * @author zcj
- * @version 0.1
- * @date 2020/4/3 3:57 下午
- */
-public class JwtUtil implements Serializable {
-
-}